|Summary:||PropertiesChunk.writeProperties: do not write ASCII_STRING properties as UNICODE_STRING|
|Product:||POI||Reporter:||Dominik Hölzl <dominik.hoelzl>|
|Component:||HSMF||Assignee:||POI Developers List <dev>|
Description Dominik Hölzl 2019-05-17 09:57:50 UTC
PropertiesChunk.writeProperties: ASCII_STRING properties must be written as ASCII_STRING properties but not UNICODE_STRING as written raw value (PropertyValue.getRawValue) is formatted as ASCII_STRING. Without this fix writing a MSG with ASCII strings causes the strings to be written with UNICODE type information but ASCII string content which causes the ASCII strings interpreted as UNICODE when re-opened. See https://github.com/apache/poi/pull/146
Comment 1 PJ Fanning 2019-05-17 12:25:46 UTC
Change looks ok to me - but it would be good if someone who knows more about the old H**F formats could also review this.