Summary: | Custom properties "add" method is slow | ||
---|---|---|---|
Product: | POI | Reporter: | serhiy <serhiy.boychenko> |
Component: | XSSF | Assignee: | POI Developers List <dev> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | P2 | ||
Version: | 4.0.0-FINAL | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux |
Description
serhiy
2019-09-26 09:09:30 UTC
Hello, sorry for replying to a resolved issue, but I still have some concerns about the proposed solution. I am not really familiar with XSLSX format and therefore I do not know if "pid" must be unique or not. In case it must be unique, it is maybe better to use AtomicInteger or something similar, as in concurrent code execution there is a chance of two different properties ending up with same pid, otherwise ignore this comment. The second concern I have is "if(contains(name))" in "add" method, according to my experimentation, this method is also slow and leads to a bad performance after reaching around 2000 entries in Custom Properties. Therefore I am wondering if the names should be also cached into a temporary set to improve performance. Sorry once again for bumping the issue. Best regards, Serhiy. In which release are these changes? should be in 4.1.1 |