Summary: | ScriptFilter has no way to reuse it | ||
---|---|---|---|
Product: | Ant | Reporter: | Robert Flaherty <robert.flaherty> |
Component: | Documentation | Assignee: | Ant Notifications List <notifications> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | ||
Priority: | P2 | ||
Version: | 1.10.8 | ||
Target Milestone: | 1.10.9 | ||
Hardware: | PC | ||
OS: | All |
Description
Robert Flaherty
2020-07-15 14:08:02 UTC
- One other idea is if FilterChain could support the id/refid combo. I don't know if FilterChains can be nested, but that may also be desirable. I think <filterchain> can be defined once and reused via refid later. Doesn't this work? Well, the FilterChain worked. Firstly, can this be turned into a doc bug for the "Manual" docs: - The "FilterChains and FilterReaders" section has no grid of info for FilterChain; I think "refid" is the only attribute. - Looking at the JavaDocs, anything extending from DataType would support the "refid", but that should be documented in the corresponding "Manual" docs. I don't see "refid" for FileList, FilterSet, PatternSet, etc... Secondly, is it technically possible to push the Reference concept down from DataType to ProjectComponent, where even tasks could leverage this? if you look at the actual implementations you'll see that refid by itself doesn't do anything and that all implmentations of DataType contain custom code to make it work. Pushing it down to ProjectComponent wouldn't change anything as each implementation of ProjectComponent add support for it explicitly. There isn't anything that would stop a task from implementing refid today - or from extending DataType. Tasks don't need to extend Task, they don't even have to be ProjectComponents. All that is required of a task is to have a no-arg void execure method. Pure duck-typing :-) As for the documentation there is a section of references in https://ant.apache.org/manual/using.html#references but it is not cross-references from all places where it could be. I'll try to improve that. |