|Summary:||Textarea Colors are not good in dark modes|
|Product:||JMeter||Reporter:||Timo Leefers <ASF.Software.Timo>|
|Component:||Main||Assignee:||JMeter issues mailing list <issues>|
|Attachments:||ZIP with four screenshots - 3 from JMeter 5.3 and 1 from JMeter 5.1.1|
Description Timo Leefers 2020-09-04 11:43:47 UTC
Created attachment 37421 [details] ZIP with four screenshots - 3 from JMeter 5.3 and 1 from JMeter 5.1.1 The font-color of the Text-Area is not change when switch the LAF. This causes that the text is not good readable. In JMeter 5.1.1 switching to the darcula LAF the font-colors changed so that everything was good readable. Example: Create a TestPlan with a HTTP-Sampler and entry something in the RequestBody. Enter something to the Body-Data. In all bright LAF the text is readable, but in the dark ones (Darklaf-Dracula, Darklaf-Onedark, Darklaf-SolarizedDark) the text hard to read (Black text und dark backgrounds). But with Darklaf-HighContrastDark it's impossible to read (Black text on black background) - only the marked text and the active row are readable. (see Screenshots) The same issue happen in the "View Results Tree", when viewing the request- and resonde data (Body and Headers).
Comment 2 Philippe Mouawad 2020-10-24 15:15:22 UTC
pmouawad pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/jmeter.git The following commit(s) were added to refs/heads/master by this push: new 1bc58f4 Use theme from darklaf extensions for RSyntaxTextArea. (#617) 1bc58f4 is described below commit 1bc58f4c65b812751439d94ce4f31bbb4923d132 Author: Jannis Weis <31143295+weisJ@users.noreply.github.com> AuthorDate: Wed Sep 9 18:01:27 2020 +0200 Use theme from darklaf extensions for RSyntaxTextArea. (#617) --- gradle.properties | 3 +- src/bom/build.gradle.kts | 1 + src/core/build.gradle.kts | 1 + .../jmeter/gui/action/LookAndFeelCommand.java | 10 ++--- .../apache/jmeter/gui/util/JSyntaxTextArea.java | 44 ++++++++++++++-------- 5 files changed, 37 insertions(+), 22 deletions(-)
Comment 3 Timo Leefers 2020-10-27 11:00:56 UTC
I've tested it in the nightly of today 2020-10-27. And now that look very well. Thank you for fixing this issue.