Bug 64870

Summary:	ClassNotFoundException on RFC2231Utility when parsing parameters
Product:	Tomcat 9	Reporter:	Dave Snyckers <dave.snyckers>
Component:	Catalina	Assignee:	Tomcat Developers Mailing List <dev>
Status:	RESOLVED INVALID
Severity:	normal
Priority:	P2
Version:	9.0.39
Target Milestone:	-----
Hardware:	All
OS:	All

Description Dave Snyckers 2020-11-04 13:30:17 UTC

Using spring-boot 2.3.5.RELEASE (including tomcat-embed-core 9.0.39) following error occurs when trying to parse parameters if multipart/form-data is used as Content-Type:

Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.springframework.web.multipart.MultipartException: Failed to parse multipart servlet request; nested exception is java.lang.NoClassDefFoundError: org/apache/tomcat/util/http/fileupload/util/mime/RFC2231Utility] with root cause

java.lang.ClassNotFoundException: org.apache.tomcat.util.http.fileupload.util.mime.RFC2231Utility
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:581) ~[na:na]
	at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) ~[na:na]
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:522) ~[na:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.ParameterParser.parse(ParameterParser.java:331) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.ParameterParser.parse(ParameterParser.java:278) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.ParameterParser.parse(ParameterParser.java:261) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.ParameterParser.parse(ParameterParser.java:245) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.FileUploadBase.getBoundary(FileUploadBase.java:367) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.impl.FileItemIteratorImpl.init(FileItemIteratorImpl.java:171) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.impl.FileItemIteratorImpl.getMultiPartStream(FileItemIteratorImpl.java:190) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.impl.FileItemIteratorImpl.findNextItem(FileItemIteratorImpl.java:209) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.impl.FileItemIteratorImpl.<init>(FileItemIteratorImpl.java:127) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.FileUploadBase.getItemIterator(FileUploadBase.java:256) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.http.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:280) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.connector.Request.parseParts(Request.java:2869) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.connector.Request.getParts(Request.java:2771) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.connector.RequestFacade.getParts(RequestFacade.java:1098) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.multipart.support.StandardMultipartHttpServletRequest.parseRequest(StandardMultipartHttpServletRequest.java:95) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.multipart.support.StandardMultipartHttpServletRequest.<init>(StandardMultipartHttpServletRequest.java:88) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.multipart.support.StandardServletMultipartResolver.resolveMultipart(StandardServletMultipartResolver.java:87) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.DispatcherServlet.checkMultipart(DispatcherServlet.java:1178) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1012) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:943) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1006) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.FrameworkServlet.doPost(FrameworkServlet.java:909) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/javax.servlet.http.HttpServlet.service(HttpServlet.java:652) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.webmvc@5.2.10.RELEASE/org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:883) ~[spring-webmvc-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/javax.servlet.http.HttpServlet.service(HttpServlet.java:733) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:231) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:100) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.FormContentFilter.doFilterInternal(FormContentFilter.java:93) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.boot.actuator@2.3.5.RELEASE/org.springframework.boot.actuate.metrics.web.servlet.WebMvcMetricsFilter.doFilterInternal(WebMvcMetricsFilter.java:93) ~[spring-boot-actuator-2.3.5.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.39.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:201) ~[spring-web-5.2.10.RELEASE.jar:na]
	at spring.web@5.2.10.RELEASE/org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:119) ~[spring-web-5.2.10.RELEASE.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:193) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:166) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:202) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:97) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:542) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:143) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:92) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:78) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:374) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:65) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:868) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1590) ~[tomcat-embed-core-9.0.39.jar:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:49) ~[tomcat-embed-core-9.0.39.jar:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) ~[na:na]
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) ~[na:na]
	at org.apache.tomcat.embed.core@9.0.39/org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) ~[tomcat-embed-core-9.0.39.jar:na]
	at java.base/java.lang.Thread.run(Thread.java:834) ~[na:na]

What we already discovered is:
- in the module-info of tomcat-embed-core, no export for the org.apache.tomcat.util.http.fileupload.util.mime package is present currently
- if we patch tomcat-embed-core 9.0.39 and add 'exports org.apache.tomcat.util.http.fileupload.util.mime;' to the module-info, the ClassNotFoundException does not occur anymore.

Comment 1 Mark Thomas 2020-11-04 13:47:36 UTC

Adding to the list of exports is a reasonable short-term work-around.

At first glance this looks like a similar issue I am in the middle of working on. The root cause may not be in Tomcat. I'll update this when I have more info.

Comment 2 Mark Thomas 2020-11-06 11:14:09 UTC

Confirmed, this is a symptom of a JRE bug https://bugs.openjdk.java.net/browse/JDK-8255854

The bnd folks have been brilliant and have already implemented a work-around. Tomcat 10 has been updated to use the workaround and 9.0.x will follow shortly.

I am closing this is INVALID merely on a technicality because the root cause is a JRE issue rather than a Tomcat bug. Rest assured the work-around will be in place for 10.0.0-M10 and 9.0.40 onwards.