Bug 64959

Summary: [PATCH] PackagePart#flush is unused
Product: POI Reporter: Marius Volkhart <marius>
Component: OPCAssignee: POI Developers List <dev>
Status: RESOLVED WONTFIX    
Severity: enhancement Keywords: PatchAvailable
Priority: P2    
Version: 4.1.2-FINAL   
Target Milestone: ---   
Hardware: All   
OS: All   

Description Marius Volkhart 2020-12-06 01:25:34 UTC 
This method is never called by the POI code, and none of the built-in implementations have meaningful implementation of the method.

PackagePropertiesPart#flush() was called in one location, but as the implementation is empty, the call is unnecessary.

There's no bug here, rather, there's just code that is essentially dead.
Comment 1 Marius Volkhart 2020-12-06 01:27:57 UTC 
PR available https://github.com/apache/poi/pull/202
Comment 2 PJ Fanning 2021-10-31 09:25:20 UTC 
I don't think we want to implement this - Marius closed the PR - Marius, please feel free to reopen if you feel strongly about this.