Bug 65329

Summary: Incorrect handling for WINVER in NMAKEmakefile
Product: Tomcat Native Reporter: Michael Osipov <michaelo>
Component: LibraryAssignee: Tomcat Developers Mailing List <dev>
Status: RESOLVED FIXED    
Severity: major CC: michaelo
Priority: P2    
Version: 1.2.28   
Target Milestone: ---   
Hardware: PC   
OS: All   

Description Michael Osipov 2021-05-25 16:36:38 UTC 
The supplied NMAKEmakefiles

* does not recognize Windows releases after 7 (8, 8.1, 10),
* passes incorrect macro values to activate features in the compiler, e.g,  -D_WIN32_WINNT=0x0700 for Windows 7. The value is wrong.

Proper values are documented here:
* https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-160
* https://docs.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversioninfoa

So those files need to add new values and fix existing incorrect values.
Comment 1 Michael Osipov 2021-05-25 19:35:47 UTC 
Yet another resource: https://docs.microsoft.com/en-us/windows/win32/winprog/using-the-windows-headers
Comment 2 Mark Thomas 2021-06-01 08:52:13 UTC 
Fixed for 1.2.30 onwards.