| Summary: | XSLFSheet.importBlip overrides relation IDs | ||
|---|---|---|---|
| Product: | POI | Reporter: | Max <0x00ten> |
| Component: | XSLF | Assignee: | POI Developers List <dev> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | roman.melnik |
| Priority: | P2 | ||
| Version: | 5.0.x-dev | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | All | ||
| Attachments: |
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class |
||
thanks - but can you provide a unit test? Created attachment 38107 [details]
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Hi. Sure, updated the patch.
Created attachment 38108 [details]
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Comment on attachment 38107 [details]
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
importBlip is not a public method? Do you have a test case that reproduces your issue that only uses public methods? It's possible that you are not using the APIs like they were intended to be used.
Created attachment 38109 [details]
Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class
Updated the patch with a test with a real presentation.
Comment on attachment 38109 [details] Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class this change seems to make this test fail - TestXSLFBugs > bug62587() FAILED org.opentest4j.AssertionFailedError at TestXSLFBugs.java:291 there could be more issues Comment on attachment 38108 [details] Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class made a preliminary commit - r1895405 - will follow up and add extra tests if this doesn't cause more problems |
Created attachment 38106 [details] Fix overriding relation IDs in the "importBlip" method of the "XSLFSheet" class The "importBlip" method of the "XSLFSheet" class creates relations with the same IDs as the original blips causing possible collisions.