|Summary:||[PATCH] Strings not recognized by org.apache.poi.hssf.record.formula.Ptg|
|Product:||POI||Reporter:||Werner Froidevaux <wfro>|
|Component:||HSSF||Assignee:||POI Developers List <dev>|
Sample implementation of StringPtg
Patch for Ptg
Patch for Ptg
Patch for TestFormulaParser
Description Werner Froidevaux 2002-05-26 01:15:19 UTC
String constants (sid=x017) (e.g. a cell containing '= "ABCD"') are not recognined by Ptg. An unknown PTG exception is thrown.
Comment 1 Werner Froidevaux 2002-05-26 01:17:15 UTC
Created attachment 1944 [details] Sample implementation of StringPtg
Comment 3 Andy Oliver 2002-05-26 22:10:22 UTC
Hi.. Not trying to be a pain but can you do this: 1. Make a unit test for #1 2. attach an actual *patch* for #2 (to make a patch, get the HEAD from CVS, make your changes to your working copy, type cvs diff -u > mypatch.patch) This does a couple things: 1 - I can tell what version its against 2 - I can tell exactly what is changed 3 - People who are impatient can patch their local copies 4 - keeps a nice history. I apprecaite your work. Sorry if it looks like I'm pulling teeth on the pedantics.
Comment 5 Andy Oliver 2002-05-26 23:20:33 UTC
applied.. . please cross check
Comment 6 Werner Froidevaux 2002-05-26 23:35:50 UTC
Created attachment 1954 [details] Patch for TestFormulaParser
Comment 7 Andy Oliver 2002-05-27 21:19:57 UTC
avik please look at this. -- I've not applied as it looks like we'd be playing in the same area.
Comment 8 Avik Sengupta 2002-05-28 12:47:38 UTC