Bug 11251 - HPSF test cases don't run
Summary: HPSF test cases don't run
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: unspecified
Hardware: Other other
: P3 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-07-29 13:18 UTC by Rainer Klute
Modified: 2004-11-16 19:05 UTC (History)
1 user (show)



Attachments
Patch to apply to the origin of tools/cents/junit.cent/xbuild.xml (562 bytes, patch)
2002-07-29 13:22 UTC, Rainer Klute
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Klute 2002-07-29 13:18:11 UTC
I created some test cases that run flawlessly on my machine. However, I don't
know how to integrate them into the build properly. The test case needs a system
property HPSF.testdata.path (analogous to HSSF.testdata.path) which gets set in
tools/cents/junit.cent/xbuild.xml.

However, this file is not in the CVS and obviously generated by the first build.
Since I don't know where it stems from, I'd like to ask a committer who has The
Knowlegde to integrate the attached patch at the proper place. Thanks!

(I wonder why nobody noticed this before since this test case must have failed
since more than a week.)
Comment 1 Rainer Klute 2002-07-29 13:22:09 UTC
Created attachment 2516 [details]
Patch to apply to the origin of tools/cents/junit.cent/xbuild.xml
Comment 2 Andy Oliver 2002-07-29 13:38:10 UTC
is there a reason this can't be added to
http://cvs.apache.org/viewcvs/jakarta-poi/layout.xml ?

I've just been deleting this test case to get my build to continue.  Its been
showing up as failed here: http://jakarta.apache.org/poi/tests/junit/
Comment 3 Glen Stampoultzis 2002-07-29 13:43:07 UTC
I don't suppose you have time to modify your script to email the list if there
are failing test cases?

Also, on an unrelated issue.  Do you know how to fix the gump error's we've been
getting?
Comment 4 Rainer Klute 2002-07-29 14:10:36 UTC
I cannot see how I could add the HPSF test cases to layout.xml. I added a
<sysproperty> element for HPSF.testdata.path to build.xml, but this does not
seem to have any effect.
Comment 5 Andy Oliver 2002-07-29 14:27:53 UTC
check on how this is done in HSSF.  Several tests use a path variable of some sort.
Comment 6 Rainer Klute 2002-07-29 14:48:46 UTC
I did. That's why I changed build.xml. And that's why I changed
tools/cents/junit.cent/xbuild.xml locally. But only the latter seems to have an
effect on setting the system property for the HPSF test cases.

Comment 7 Andy Oliver 2002-07-29 15:07:50 UTC
okay...maybe ken knows what to do here.
Comment 8 Rainer Klute 2002-07-30 15:06:17 UTC
I discovered that the original of tools/cents/junit.cent/xbuild.xml is located
in tools/cents/jdepend.cent.jar and must be modified in the JAR. (At least the
HPSF test cases run now.)
Comment 9 Andy Oliver 2002-07-30 16:10:17 UTC
suggestion: Send email to ken to make sure he notices this so that he doesn't
overwrite this next time he works on the build.
Comment 10 Rainer Klute 2002-07-31 09:40:16 UTC
Done.