Bug 13563 - StringTagSupport is broken for tag handler reuse
Summary: StringTagSupport is broken for tag handler reuse
Status: RESOLVED FIXED
Alias: None
Product: Taglibs
Classification: Unclassified
Component: String Taglib (show other bugs)
Version: 1.0
Hardware: All All
: P3 major (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-10-12 00:20 UTC by Martin Cooper
Modified: 2004-11-16 19:05 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Cooper 2002-10-12 00:20:16 UTC
The tags in the String taglib which extend StringTagSupport are broken for 
containers which reuse tag handler instances. The problem is in 
StringTagSupport.java, where initAttributes() is being called from within 
doEndTag(). Since the container is not required to reinitialise the attributes 
for a tag handler instance if they have the same values - which they might do 
in a loop, for example - the tag produces incorrect results after the first 
call.

The fix is simply to remove the call to initAttributes() from doEndTag().
Comment 1 Henri Yandell 2002-11-30 21:08:02 UTC
This is fixed in the CVS tree and highlighted on the website [or will be when the website 
changes propagate through].