Bug 19419 - WebdavResource.java does not release connections
Summary: WebdavResource.java does not release connections
Status: NEW
Alias: None
Product: Slide
Classification: Unclassified
Component: WebDAV client (show other bugs)
Version: Nightly
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---
Assignee: Slide Developer List
URL:
Keywords:
Depends on:
Blocks: 31521
  Show dependency tree
 
Reported: 2003-04-29 09:37 UTC by Max Kellermann
Modified: 2004-11-16 19:05 UTC (History)
1 user (show)


Attachments
add all missing method.releaseConnection() calls in WebdavResource.java (13.94 KB, patch)
2004-10-20 09:20 UTC, Max Kellermann 		Details | Diff
just found a typo in my previous patch.. releaseConnection() shouldn't be there in getMethodDataAsString() (13.68 KB, patch)
2004-10-20 10:27 UTC, Max Kellermann 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Kellermann 2003-04-29 09:37:02 UTC 
on some methods where the returned response body is not evaluated, the
HttpConnection is not released in WebdavResource.java. Examples for affected
methods: mkcolMethod, putMethod. Many others are affected.

Fix: add the following line after the "executeMethod" line:

  method.releaseConnection();
Comment 1 Max Kellermann 2004-10-20 09:20:21 UTC 
Created attachment 13151 [details]
add all missing method.releaseConnection() calls in WebdavResource.java
Comment 2 Max Kellermann 2004-10-20 09:20:48 UTC 
by the way, the patch was for Slide 2.1b2
Comment 3 Max Kellermann 2004-10-20 10:27:23 UTC 
Created attachment 13153 [details]
just found a typo in my previous patch.. releaseConnection() shouldn't be there in getMethodDataAsString()