Bug 19675 - Performance/code cleanliness nit in proxy_util.c
Summary: Performance/code cleanliness nit in proxy_util.c
Status: RESOLVED WONTFIX
Alias: None
Product: Apache httpd-1.3
Classification: Unclassified
Component: mod_proxy (show other bugs)
Version: 1.3.27
Hardware: All All
: P3 minor (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2003-05-05 16:16 UTC by Daniel Martin
Modified: 2007-08-02 11:59 UTC (History)
0 users


Attachments
proxy_util.c patch (830 bytes, patch)
2003-05-05 16:17 UTC, Daniel Martin 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Martin 2003-05-05 16:16:56 UTC 
Version 1.126 of proxy_util.c was created to fix bugs 10026 and 11668, and it
does fix them.

However, I feel that the fix introduced is wasteful in that it does a strlen
followed by a ap_pstrcat, when a simple one-character check and one-character
assignment is sufficient.

I'll attach a patch showing the change I propose.
Comment 1 Daniel Martin 2003-05-05 16:17:25 UTC 
Created attachment 6217 [details]
proxy_util.c patch
Comment 2 Jeff Trawick 2003-11-21 18:16:42 UTC 
I'm going through the bug db to make sure patches are findable.  Please see 
http://httpd.apache.org/dev/patches.html