Bug 24006 - PROPPATCH vs Allow header
Summary: PROPPATCH vs Allow header
Alias: None
Product: Tomcat 4
Classification: Unclassified
Component: Servlets:WebDAV (show other bugs)
Version: 4.1.27
Hardware: Other other
: P3 minor with 1 vote (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL: http://greenbytes.de/tech/webdav/rfc2...
Depends on:
Reported: 2003-10-22 14:41 UTC by Julian Reschke
Modified: 2004-11-16 19:05 UTC (History)
0 users

Patch for TC5 to fix this bug. (4.76 KB, patch)
2003-11-13 23:11 UTC, Mark Thomas
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Reschke 2003-10-22 14:41:04 UTC
For a plain file, OPTIONS returns "PROPPATCH" as allowed method ("Allow"
header). However, an attempt to PROPPATCH the resource returns a 405 status
("not allowed").

Issues here:

- If PROPPATCH is not allowed, OPTIONS should say so
- RFC2616 (section 10.4.6) requires returning an "Allow" header whenever the
response was a 405 (this doesn't happen)
Comment 1 Mark Thomas 2003-11-13 23:11:11 UTC
I have a patch for this bug which I will attach.

Currently PROPPATCH always returns 405 as it hasn't been implemented. The 
patch changes this to return 501 (not implemented). Even with the patch, this 
bug should be left open with a severity of enhancement until this 
functionality is developed.

There are a number of places where a 405 responses is returned and none of 
them set the allow header. The patch also addresses this.
Comment 2 Mark Thomas 2003-11-13 23:11:57 UTC
Created attachment 9100 [details]
Patch for TC5 to fix this bug.
Comment 3 Remy Maucherat 2003-11-14 10:16:40 UTC
I've applied your patch, thanks.
Comment 4 Julian Reschke 2003-11-16 14:18:55 UTC
Procedural question: this was reported against Tomcat4, but was resolved in 
Tomcat5. Shouldn't the issue be left open?

What's the general policy about reporting/resolving issues in Tomcat4 and 
Tomcat5? If the problem applies to both, should it reported twice?
Comment 5 Mark Thomas 2003-11-16 17:19:42 UTC
When I have fixed all the webdav issues, I'll put them all together into a 
combined TC4 patch.
Comment 6 Julian Reschke 2003-11-16 17:30:29 UTC
Sounds great, thanks.