Bug 24711 - [PATCH] macrodef child elements should use their description attributes in error messages
Summary: [PATCH] macrodef child elements should use their description attributes in er...
Status: REOPENED
Alias: None
Product: Ant
Classification: Unclassified
Component: Core tasks (show other bugs)
Version: 1.6.0
Hardware: All other
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Ant Notifications List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2003-11-14 15:55 UTC by Matt Benson
Modified: 2009-07-31 03:51 UTC (History)
0 users



Attachments
diffs to MacroInstance.java (1.69 KB, patch)
2004-01-22 22:39 UTC, Matt Benson
Details | Diff
diffs to the test case script (1.79 KB, patch)
2004-01-22 22:39 UTC, Matt Benson
Details | Diff
diffs to the test class (1.37 KB, patch)
2004-01-22 22:40 UTC, Matt Benson
Details | Diff
new diffs to MacroInstance.java (1.69 KB, patch)
2004-01-28 23:42 UTC, Matt Benson
Details | Diff
new diffs to the MacroDef test case (1.40 KB, patch)
2004-01-28 23:42 UTC, Matt Benson
Details | Diff
new diffs to the macrodef test case Ant file (1.79 KB, patch)
2004-01-28 23:43 UTC, Matt Benson
Details | Diff
handle text description (2.31 KB, patch)
2004-01-28 23:56 UTC, Matt Benson
Details | Diff
test case; handle text description (1.60 KB, patch)
2004-01-28 23:56 UTC, Matt Benson
Details | Diff
test script; handle text description (2.07 KB, patch)
2004-01-28 23:56 UTC, Matt Benson
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Benson 2003-11-14 15:55:14 UTC
The macro creator should be able to supply a description in the <element> 
element informing the user what nested contents are expected.
Comment 1 peter reilly 2004-01-08 17:37:38 UTC
Added a description attribute to the element and to the attribute
elements.
Comment 2 Matt Benson 2004-01-22 22:38:27 UTC
Thanks, Peter.  However, I originally envisioned the descriptions as showing up 
in error output.  Attachments forthcoming...
Comment 3 Matt Benson 2004-01-22 22:39:29 UTC
Created attachment 10067 [details]
diffs to MacroInstance.java
Comment 4 Matt Benson 2004-01-22 22:39:59 UTC
Created attachment 10068 [details]
diffs to the test case script
Comment 5 Matt Benson 2004-01-22 22:40:29 UTC
Created attachment 10069 [details]
diffs to the test class
Comment 6 Matt Benson 2004-01-28 23:42:31 UTC
Created attachment 10132 [details]
new diffs to MacroInstance.java
Comment 7 Matt Benson 2004-01-28 23:42:54 UTC
Created attachment 10133 [details]
new diffs to the MacroDef test case
Comment 8 Matt Benson 2004-01-28 23:43:17 UTC
Created attachment 10134 [details]
new diffs to the macrodef test case Ant file
Comment 9 Matt Benson 2004-01-28 23:48:48 UTC
patches 4, 5, and 6 affect attributes and elements and contain the nested text 
changes.
Comment 10 Matt Benson 2004-01-28 23:56:02 UTC
Created attachment 10135 [details]
handle text description
Comment 11 Matt Benson 2004-01-28 23:56:30 UTC
Created attachment 10136 [details]
test case; handle text description
Comment 12 Matt Benson 2004-01-28 23:56:44 UTC
Created attachment 10137 [details]
test script; handle text description
Comment 13 Matt Benson 2004-01-28 23:58:48 UTC
Okay... patches 7, 8, and 9 (!) add error message enhancements and related test 
cases for nested text as well... these diffs are against current CVS; i.e. they 
are not cumulative within this issue or anything.