Bug 25262 - REWRITE_SYSTEM and REWRITE_URI don't work as specified [codereview]
Summary: REWRITE_SYSTEM and REWRITE_URI don't work as specified [codereview]
Status: RESOLVED FIXED
Alias: None
Product: XmlCommons - Now in JIRA
Classification: Unclassified
Component: Resolver (show other bugs)
Version: 1.x
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Commons Developers Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2003-12-06 19:18 UTC by Jeroen N. Witmond
Modified: 2005-04-12 16:57 UTC (History)
0 users


Attachments
Move closing braces to correct place. (943 bytes, patch)
2003-12-06 19:20 UTC, Jeroen N. Witmond 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeroen N. Witmond 2003-12-06 19:18:11 UTC 
According to 
http://www.oasis-open.org/committees/download.php/2384/cs-entity-xml-catalogs-1.0.html#s.rewritesystem 
and 
http://www.oasis-open.org/committees/download.php/2384/cs-entity-xml-catalogs-1.0.html#s.rewriteuri 
"If more than one entry matches, the matching entry with the longest normalized StartString 
value is used." 
 
However, when I review the code it would seem that, due to the incorrect placement of a 
closing brace in two places (resolveLocalSystem and resolveLocalURI), 
xml-commons/java/src/org/apache/xml/resolver/Catalog.java will use the first match. 
 
Please note that this report is based on code review only.
Comment 1 Jeroen N. Witmond 2003-12-06 19:20:02 UTC 
Created attachment 9424 [details]
Move closing braces to correct place.
Comment 2 Jeroen N. Witmond 2003-12-06 19:21:32 UTC 
Please note that the patch also is based on code review only; it has not been tested.
Comment 3 Norman Walsh 2005-04-13 00:57:14 UTC 
Nice catch!