Bug 25471 - Allow --enable-mods-shared=max
Summary: Allow --enable-mods-shared=max
Status: RESOLVED WONTFIX
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Build (show other bugs)
Version: 2.1-HEAD
Hardware: Other other
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2003-12-12 11:27 UTC by Mads Toftum
Modified: 2011-06-13 11:31 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Toftum 2003-12-12 11:27:39 UTC
This is really a minor thing, but every once in a while it pops up.
In 1.3 we have: --enable-shared=max
In 2.x we have: --enable-mods-shared= either most or all (no difference
between the two).
This trivial patch adds max with the same effect as most and all:
                                                                               
                                                                
Index: acinclude.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/acinclude.m4,v
retrieving revision 1.145
diff -u -r1.145 acinclude.m4
--- acinclude.m4        10 Jul 2003 19:29:24 -0000      1.145
+++ acinclude.m4        11 Dec 2003 20:20:34 -0000
@@ -292,7 +292,7 @@
   AC_ARG_ENABLE(mods-shared,
   APACHE_HELP_STRING(--enable-mods-shared=MODULE-LIST,Shared modules to enable),[
     for i in $enableval; do
-      if test "$i" = "all" -o "$i" = "most"; then
+      if test "$i" = "all" -o "$i" = "most" -o "$i" = "max"; then
         module_selection=$i
         module_default=shared
       else
                                                                               
                                                                
and similar for APACHE_2_0_BRANCH:
                                                                               
                                                                
Index: acinclude.m4
===================================================================
RCS file: /home/cvs/httpd-2.0/acinclude.m4,v
retrieving revision 1.133.2.1
diff -u -r1.133.2.1 acinclude.m4
--- acinclude.m4        29 Nov 2002 11:05:57 -0000      1.133.2.1
+++ acinclude.m4        11 Dec 2003 20:26:09 -0000
@@ -361,7 +361,7 @@
   AC_ARG_ENABLE(mods-shared,
   APACHE_HELP_STRING(--enable-mods-shared=MODULE-LIST,Shared modules to enable),[
     for i in $enableval; do
-      if test "$i" = "all" -o "$i" = "most"; then
+      if test "$i" = "all" -o "$i" = "most" -o "$i" = "max"; then
         module_selection=$i
         module_default=shared
       else
Comment 1 Stefan Fritsch 2011-06-13 11:31:18 UTC
I don't think compatibility with 1.3 is an issue any more. And by now, 'most' and 'all' are no longer the same, and we have 'reallyall'. Closing.