Bug 279 - Logical Error in GetParameterValuesTestServlet BugRat Report#522
Summary: Logical Error in GetParameterValuesTestServlet BugRat Report#522
Status: UNCONFIRMED
Alias: None
Product: Watchdog
Classification: Unclassified
Component: Servlet (show other bugs)
Version: unspecified
Hardware: All All
: P1 normal (vote)
Target Milestone: ---
Assignee: Ryan Lubke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2000-12-04 19:44 UTC by Srinivasa Villuri
Modified: 2004-11-16 19:05 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomcat Developers Mailing List 2000-12-04 19:44:46 UTC 
Or(||) and (&&) needs to be interchanged.
Here is the context diff.


diff -c GetParameterValuesTestServlet.java.old /usr2/download/Jakarta/jakarta-watchdog/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet/ServletRequest/GetParameterValuesTestServlet.java
*** GetParameterValuesTestServlet.java.old  Mon Dec  4 17:06:56 2000
--- /usr2/download/Jakarta/jakarta-watchdog/src/server/servlet-tests/WEB-INF/classes/tests/javax_servlet/ServletRequest/GetParameterValuesTestServlet.java      Mon Dec  4 17:09:36 2000
***************
*** 101,110 ****
                if(vals.length == 2) {
  
                        if((vals[0].equals("sun")
!                               ||vals[1].equals("javasoft")) &&
  
!                               (vals[0].equals("sun")||
!                                       vals[1].equals("javasoft"))) {
  
                                msg="OK";
                                status="true";
--- 101,110 ----
                if(vals.length == 2) {
  
                        if((vals[0].equals("sun")
!                               &&vals[1].equals("javasoft")) ||
  
!                               (vals[0].equals("javasoft")&&
!                                       vals[1].equals("sun"))) {
  
                                msg="OK";
                                status="true";