Bug 29696 - does not log request completion time even with #define I_INSIST_ON_EXTRA_CYCLES_FOR_CLF_COMPLIANCE
Summary: does not log request completion time even with #define I_INSIST_ON_EXTRA_CYCL...
Status: CLOSED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_log_config (show other bugs)
Version: 2.0.46
Hardware: All All
: P3 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2004-06-20 11:25 UTC by Alois Treindl
Modified: 2004-11-16 19:05 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alois Treindl 2004-06-20 11:25:29 UTC
file modules/loggers/mod_log_config.c
has a special #define  I_INSIST_ON_EXTRA_CYCLES_FOR_CLF_COMPLIANCE
which has the purpose that logfile timestamps log the completion time
of a request, and not the new 2.0 default, which is the begin time of a request.

This #define does not work for Customlog, because of a bug:
r->request_time is used anyway!

The patch is
@@ -556,7 +548,7 @@
             char sign;
             int timz;

-            ap_explode_recent_localtime(&xt, r->request_time);
+            ap_explode_recent_localtime(&xt, request_time);
             timz = xt.tm_gmtoff;
             if (timz < 0) {
                 timz = -timz;
Comment 1 Jeff Trawick 2004-06-20 13:09:38 UTC
Fix committed to 2.1-dev, and I'll propose it for merging into stable branch for
2.0.next.

Thanks for the fix, and thanks for using Apache httpd!