Bug 31127 - ap_get_scoreboard_{worker,process} has to lax range checks
Summary: ap_get_scoreboard_{worker,process} has to lax range checks
Status: RESOLVED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.0-HEAD
Hardware: All other
: P5 minor with 2 votes (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2004-09-08 18:25 UTC by Christian von Roques
Modified: 2007-10-23 20:59 UTC (History)
0 users



Attachments
Patch fixing index checks in ap_get_scoreboard_{worker,process} (1.35 KB, patch)
2004-09-08 18:28 UTC, Christian von Roques
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian von Roques 2004-09-08 18:25:37 UTC
The scoreboard has space for server_limit parents
and server_limit*thread_limit workers, but
ap_get_scoreboard_{worker,process} allow indizes
0 ... server_limit and 0 ... thread_limit inclusive,
but they only should allow
0 ... server_limit-1 and 0 ... thread_limit-1

If the rest of the code is correct, they
probably won't be called with bad arguments,
thus this is mostly of code cosmetic interrest.
Comment 1 Christian von Roques 2004-09-08 18:28:36 UTC
Created attachment 12673 [details]
Patch fixing index checks in ap_get_scoreboard_{worker,process}
Comment 2 William A. Rowe Jr. 2007-10-23 20:59:19 UTC
Apparently this was fixed some time ago, I just managed to 'unfix it' but
I've restored your recommended behavior.  Thanks for the submission!