Bug 32431 - Misc errors in CGIServlet
Summary: Misc errors in CGIServlet
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Servlets:CGI (show other bugs)
Version: 5.0.30
Hardware: PC Windows 2000
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-29 21:16 UTC by Mark Claassen
Modified: 2004-11-29 14:45 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Claassen 2004-11-29 21:16:30 UTC 
-------------------------------------- Begin At Line 1668 
if(contentStream != null) {
      commandsStdIn = new BufferedOutputStream(proc.getOutputStream());
      proc.getOutputStream().write(contentStream.toByteArray());
      commandsStdIn.flush();
      commandsStdIn.close();
}
-------------------------------------- End
should probably be:
-------------------------------------- Begin At Line 1668 
if(contentStream != null) {
      commandsStdIn = new BufferedOutputStream(proc.getOutputStream());
      commandsStdIn.write(contentStream.toByteArray());
      commandsStdIn.flush();
      commandsStdIn.close();
}
-------------------------------------- End


Line 1793:
-------------------------------------- Begin At Line Line 1793
while ((line = rdr.readLine()) != null) {
      log("runCGI (stderr):" +  line) ;
}
lineCount++ ;
-------------------------------------- End
should probably be:
-------------------------------------- Begin At Line Line 1793
while ((line = rdr.readLine()) != null) {
      log("runCGI (stderr):" +  line) ;
      lineCount++ ;
}
-------------------------------------- End

The first issue is part of bug 32430, except the large file stuff looks fixed.
The second issue is bug 32429
Comment 1 Mark Thomas 2004-11-29 23:09:39 UTC 
The second issue has been fixed - see bug 32429

The first issue has been fixed in CVS for 4.1.x and 5.5.x

Thanks for the patch.

In future please try not to duplicate reports across multiple bugzilla entries 
as it makes tracking which bugs have been fixed and which ones haven't a lot 
more difficult.
Comment 2 Mark Claassen 2004-11-29 23:13:43 UTC 
Sorry about the duplication.  Any chance these will make it into 5.0.30?
Comment 3 Mark Thomas 2004-11-29 23:45:31 UTC 
Now 5.5.x is stable, I wasn't planning to port the CGI stuff back to 5.0.30.