I found what I would classify as a small "broken window" (really more of a nick than a break) while debugging another problem. Below is a patch for org/apache/jasper/servlet/JspServletWrapper.java to remove unnecessary conditional statements. The change will not really have much, if any, affect on performance, although there will be fewer bytecodes, less (and simpler) source code. --- JspServletWrapper.java.orig 2005-01-24 09:40:38.000000000 -0500 +++ JspServletWrapper.java 2005-01-24 09:42:19.000000000 -0500 @@ -196,9 +196,7 @@ } if (options.getDevelopment() || firstTime ) { synchronized (this) { - if (firstTime) { - firstTime = false; - } + firstTime = false; ctxt.compile(); } } else { @@ -289,9 +287,7 @@ */ if (options.getDevelopment() || firstTime ) { synchronized (this) { - if (firstTime) { - firstTime = false; - } + firstTime = false; // The following sets reload to true, if necessary ctxt.compile(); }
Changing severity.
Done. Thanks for reporting the patch.