Bug 33454 - escape sequences passed to ap_log_error
Summary: escape sequences passed to ap_log_error
Status: CLOSED FIXED
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.1-HEAD
Hardware: All All
: P5 trivial (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2005-02-08 22:55 UTC by Eric Covener
Modified: 2005-03-03 02:57 UTC (History)
0 users


Attachments
removes control characters from caller (4.04 KB, patch)
2005-02-08 23:14 UTC, Eric Covener 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Covener 2005-02-08 22:55:53 UTC 
ap_log_error now escapes escape sequences such as newline and tab so that they
appear as the two-character strings "\t" or "\n" in error_log (unless httpd was
built with -DAP_UNSAFE_ERROR_LOG_UNESCAPED).

Some callers throughout the code still send '\n' within the string argument sent
to ap_log_error, trivial patch attached removes the formatting from these calls
(escaped formatting would obscure things vs. make them stand out as I presume
the formatting was intended for)
Comment 1 Eric Covener 2005-02-08 23:14:27 UTC 
Created attachment 14220 [details]
removes control characters from caller
Comment 2 Joe Orton 2005-03-02 22:07:59 UTC 
[assigned-to should be left at bugs@httpd.apache.org for mailing list tracking
purposes]
Comment 3 Jeff Trawick 2005-03-03 11:57:36 UTC 
still needs 1 more vote to backport to 2.0.54-dev