Bug 35250 - [PatchAvailable] add logging to mod_proxy_connect on failed connect
Summary: [PatchAvailable] add logging to mod_proxy_connect on failed connect
Status: RESOLVED LATER
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_proxy (show other bugs)
Version: 2.0-HEAD
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: MassUpdate, PatchAvailable
Depends on:
Blocks:
 
Reported: 2005-06-07 00:40 UTC by eddie
Modified: 2018-11-07 21:08 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description eddie 2005-06-07 00:40:22 UTC
Adding logging when ap_proxy_connect_handler fails to connect (two XXX's and 
two extra ones)

Index: modules/proxy/proxy_connect.c
===================================================================
--- modules/proxy/proxy_connect.c       (revision 185054)
+++ modules/proxy/proxy_connect.c       (working copy)
@@ -154,12 +154,12 @@
            case APR_URI_SNEWS_DEFAULT_PORT:
                break;
            default:
-                /* XXX can we call ap_proxyerror() here to get a nice log 
message? */
-               return HTTP_FORBIDDEN;
+          return ap_proxyerror(r, HTTP_FORBIDDEN,
+                            "Connect to remote machine blocked");
        }
     } else if(!allowed_port(conf, uri.port)) {
-        /* XXX can we call ap_proxyerror() here to get a nice log message? */
-       return HTTP_FORBIDDEN;
+       return ap_proxyerror(r, HTTP_FORBIDDEN,
+                            "Connect to remote machine blocked");
     }

     /*
@@ -194,10 +194,12 @@
     /* handle a permanent error from the above loop */
     if (failed) {
         if (proxyname) {
-            return DECLINED;
+                       return ap_proxyerror(r, DECLINED,
+                            "Connect to remote machine declined");
         }
         else {
-            return HTTP_BAD_GATEWAY;
+                       return ap_proxyerror(r, HTTP_BAD_GATEWAY,
+                            "Connect to remote machine failed - 
HTTP_BAD_GATEWAY");
         }
     }
Comment 1 Christophe JAILLET 2013-10-07 18:34:00 UTC
This has been partially addressed (the 2 XXX) in 2.4.x in r813178
Comment 2 William A. Rowe Jr. 2018-11-07 21:08:56 UTC
Please help us to refine our list of open and current defects; this is a mass update of old and inactive Bugzilla reports which reflect user error, already resolved defects, and still-existing defects in httpd.

As repeatedly announced, the Apache HTTP Server Project has discontinued all development and patch review of the 2.2.x series of releases. The final release 2.2.34 was published in July 2017, and no further evaluation of bug reports or security risks will be considered or published for 2.2.x releases. All reports older than 2.4.x have been updated to status RESOLVED/LATER; no further action is expected unless the report still applies to a current version of httpd.

If your report represented a question or confusion about how to use an httpd feature, an unexpected server behavior, problems building or installing httpd, or working with an external component (a third party module, browser etc.) we ask you to start by bringing your question to the User Support and Discussion mailing list, see [https://httpd.apache.org/lists.html#http-users] for details. Include a link to this Bugzilla report for completeness with your question.

If your report was clearly a defect in httpd or a feature request, we ask that you retest using a modern httpd release (2.4.33 or later) released in the past year. If it can be reproduced, please reopen this bug and change the Version field above to the httpd version you have reconfirmed with.

Your help in identifying defects or enhancements still applicable to the current httpd server software release is greatly appreciated.