Bug 35303 - Response flushing callbacks uninitialised
Summary: Response flushing callbacks uninitialised
Status: RESOLVED FIXED
Alias: None
Product: Tomcat Connectors
Classification: Unclassified
Component: Common (show other bugs)
Version: unspecified
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-10 00:37 UTC by Tim Whittington
Modified: 2008-10-05 03:09 UTC (History)
0 users


Attachments
Flush parameter initialisation (561 bytes, patch)
2005-06-10 00:37 UTC, Tim Whittington 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Whittington 2005-06-10 00:37:02 UTC 
The two fields of jk_ws_service_t added for response flushing (flush and
flush_packets) are not initialised for all connectors - currently only the
Apache 1.3 ans 2.0 connectors.

This results in their use in the AJP callbacks in jk_ajp_common.c potentially
accessing unitialised data - this is the case when the ISAPI redirector is used.

The fix is to initialise the two fields in jk_init_ws_service. 
Patch against r1.49 is attached.
Comment 1 Tim Whittington 2005-06-10 00:37:54 UTC 
Created attachment 15362 [details]
Flush parameter initialisation

Patch against jk_util.c r1.69
Comment 2 Tim Whittington 2005-06-10 05:24:36 UTC 
This is actually incorrect. MLR on my part.
It'd probably still be more robust if these were inited in jk_init_ws_service.
Comment 3 Rainer Jung 2008-01-01 16:04:44 UTC 
This has been cleaned up for version 1.2.27.