Bug 35968 - Please make Environment Entry Properties Value input a textarea
Summary: Please make Environment Entry Properties Value input a textarea
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Webapps:Administration (show other bugs)
Version: 5.5.9
Hardware: Other other
: P2 normal (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-02 04:32 UTC by Seth Ladd
Modified: 2006-10-02 18:38 UTC (History)
0 users


Attachments
Patch for tomcat/container/tc5.5.x (574 bytes, patch)
2006-05-01 12:43 UTC, Tristan Marly 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Seth Ladd 2005-08-02 04:32:48 UTC 
Hello,

Please change the  Environment Entry Properties value input type to a textarea,
instead of a text field.  We sometimes need to input multiline values here, and
a textarea would make this much easier.

Otherwise, really enjoying the admin webapp.  Very useful!

Thanks,
Seth
Comment 1 Yoav Shapira 2006-04-14 15:03:31 UTC 
Sigh, I've been meaning to get to this for months, but to no avail ;(  I see it
every time I go over the bugs before cutting a release, but never do it.  Seth,
if you still care about this and want to send it a patch, I'll gladly review it
and commit it as relevant.
Comment 2 Tristan Marly 2006-05-01 12:43:27 UTC 
Created attachment 18211 [details]
Patch for tomcat/container/tc5.5.x

Patch for the module container, version tc5.5.x.
The only impacted file is tomcat/container/webapps/admin/resources/envEntry.jsp
Comment 3 Tristan Marly 2006-05-01 14:08:22 UTC 
The following tests are successful with the patch:
- add a new env property
- edit an existing env property
- enter several lines in the textarea or a large wrapped line
- no regression with other types (integer, boolean, ...)
Comment 4 Mark Thomas 2006-10-02 18:38:00 UTC 
Patch applied. Will be included in 5.5.21 onwards.

Mnay thanks for the patch.