Bug 37451 - HSLF: Slide.getTextRuns() doesn't return text runs found in the slide's PPDrawing container
Summary: HSLF: Slide.getTextRuns() doesn't return text runs found in the slide's PPDra...
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.0-dev
Hardware: Other Windows 2000
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-10 17:40 UTC by Yegor Kozlov
Modified: 2005-11-13 09:03 UTC (History)
0 users



Attachments
text runs from PPDrawing are included in Slide.getTextRuns (963 bytes, patch)
2005-11-10 17:41 UTC, Yegor Kozlov
Details | Diff
Text Runs in a PPDrawing container (10.50 KB, application/vnd.ms-powerpoint)
2005-11-10 18:08 UTC, Yegor Kozlov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Yegor Kozlov 2005-11-10 17:40:18 UTC
Slide.getTextRuns() doesn't return all found text runs in the slide. As I see 
it is correctly initialized in Slide constructor but not included in the output 
array.
Comment 1 Yegor Kozlov 2005-11-10 17:41:50 UTC
Created attachment 16939 [details]
text runs from PPDrawing are included in Slide.getTextRuns
Comment 2 Nick Burch 2005-11-10 17:50:17 UTC
Ah, I wasn't sure if there ever would be TextRuns in there or not! I couldn't
find any with text in there, so didn't include it.

Could you attach a PPT file with them to the bug? That way, I can write a test
to go with the patch.
Comment 3 Yegor Kozlov 2005-11-10 18:06:51 UTC
Go to Insert menu and choose Text Box. Text inserted in such a way is not 
returned by your code. See the atatched ppt file.
Comment 4 Yegor Kozlov 2005-11-10 18:08:09 UTC
Created attachment 16940 [details]
Text Runs in a PPDrawing container
Comment 5 Nick Burch 2005-11-13 18:03:02 UTC
I've applied the change (with a tweak to ensure that the run array size is
correct), and added the PPT file to the test suite. Looks like it's working
properly now, but shout if you spot anything else missing.