Bug 39832 - HTML Manager improvements
Summary: HTML Manager improvements
Status: RESOLVED FIXED
Alias: None
Product: Tomcat 5
Classification: Unclassified
Component: Webapps:Manager (show other bugs)
Version: 5.5.23
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---
Assignee: Tomcat Developers Mailing List
URL: http://sourceforge.net/project/showfi...
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2006-06-17 14:49 UTC by Cédrik LIME
Modified: 2009-11-15 16:50 UTC (History)
0 users



Attachments
patch file and additional sources (383.91 KB, application/octet-stream)
2006-06-17 14:51 UTC, Cédrik LIME
Details
diff for org.apache.catalina.manager.HTMLManagerServlet.java (16.72 KB, patch)
2007-04-15 10:31 UTC, Cédrik LIME
Details | Diff
Additional source files (12.93 KB, application/octet-stream)
2007-04-15 10:34 UTC, Cédrik LIME
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Cédrik LIME 2006-06-17 14:49:28 UTC
The HTML Manager is a central point for managing an instance of Tomcat. This
tool can be greatly improved by displaying active sessions for each webapp, as
done in my open-source tool MessAdmin http://messadmin.sourceforge.net
I have back-ported and integrated part of this tool to Tomcat's HTML Manager
(please see attached patch), and am  willing to give this code to the Apache
Tomcat team.
Please note this patched manager is already used in production sites, so there
should be no problem of bugs or stability.
Do not hesitate to contact me directly in case you need more information!
Comment 1 Cédrik LIME 2006-06-17 14:51:38 UTC
Created attachment 18482 [details]
patch file and additional sources
Comment 2 Yoav Shapira 2007-03-25 14:55:13 UTC
Cedrik, thank you for your contributions.  They're greatly appreciated. 
However, we ask that contributors submit their patches in diff -u format against
existing class files.  The one big ZIP file contains a lot of things, and it's
hard to evaluate how it would fit int existing Tomcat code as well as possible
bugs / merge conflicts.

I also suggest you diff against the latest stable release on the branch you
want, e.g. 5.5.23 for the 5.5 branch or 6.0.10 for the 6.0 branch.

Thanks ;)
Comment 3 Cédrik LIME 2007-04-15 10:31:24 UTC
Created attachment 19966 [details]
diff for org.apache.catalina.manager.HTMLManagerServlet.java

This patch works along with the additional source files, as published in the
next attachment.
Comment 4 Cédrik LIME 2007-04-15 10:34:40 UTC
Created attachment 19967 [details]
Additional source files

Additional source files:
* Java classes in the "JavaSource" folder
* JSP files in the "WebContent" folder
Comment 5 Cédrik LIME 2007-04-15 10:43:26 UTC
Those last 2 attachments (19966 and 19967) are against the Tomcat 5.5.23 source.

There is one modified file (in "diff -u" format) and additional support
classes/JSPs.

I didn't have time to port this to Tomcat 6.x, but I believe it should be
straightforward. Ping me if needed, and I'll be happy to help.
Comment 6 Remy Maucherat 2007-04-16 18:55:37 UTC
I tentatively committed this submission in the 6.0.x branch. Thanks.
Comment 7 Konstantin Kolinko 2009-11-15 16:50:49 UTC
Closing as FIXED.
As per comment 6, implementation of this feature is included in Tomcat 6 and later. Backport to Tomcat 5.5 is unlikely.
Thank you.