Under high ssl load (SPECweb2005 Banking application) the acceptor thread stops
accepting new connections. The acceptor blocks in getWorkerThread() because
there isn't Worker threads available and maxThreads has been reached. The
problem is that all Worker threads are blocked waiting for a socket to process,
but this socket is never assigned because there is a leak in the Acceptor thread
code. I can attach the stacktrace of the relevant threads if necessary.

Regards,
 
- Vicenç


This modification remove the leak of Worker threads.

Index: connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java
===================================================================
--- connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java   
(revision 130)
+++ connectors/util/java/org/apache/tomcat/util/net/AprEndpoint.java    (working
copy)
@@ -980,6 +980,7 @@
          */
         public void run() {

+            Worker workerThread = null;
             // Loop until we receive a shutdown command
             while (running) {

@@ -994,12 +995,15 @@

                 try {
                     // Allocate a new worker thread
-                    Worker workerThread = getWorkerThread();
+                    if (workerThread == null)
+                        workerThread = getWorkerThread();
+
                     // Accept the next incoming connection from the server socket
                     long socket = Socket.accept(serverSock);
                     // Hand this socket off to an appropriate processor
                     if (setSocketOptions(socket)) {
                         workerThread.assign(socket);
+                        if(socket != 0) workerThread = null;
                     } else {
                         // Close socket and pool right away
                         Socket.destroy(socket);