Bug 40472 - SettingsManager calls loadSettings with global settings for Profilables
Summary: SettingsManager calls loadSettings with global settings for Profilables
Status: NEW
Alias: None
Product: Log4j - Now in Jira
Classification: Unclassified
Component: chainsaw (show other bugs)
Version: unspecified
Hardware: All other
: P2 normal
Target Milestone: ---
Assignee: log4j-dev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-11 19:31 UTC by Robert Fischer
Modified: 2006-09-11 12:31 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Fischer 2006-09-11 19:31:04 UTC
The chainsaw SettingsManager calls loadSettings(LoadSettingsEvent event) for 
classes implementing the Profilable interfaces from the loadGlobalSettings() 
method.
For these classes this isn't very useful, since at this time the 
LoadSettingsEvent doesn't contain profilable properties (they are loaded 
afterwards, in loadProfilableSettings().

Effectively, for classes implementing Profilable the 
loadSettings(LoadSettingsEvent event) method gets called twice:
- one time with global settings (which don't contain the needed properties, 
since Profilables need settings from the respective ~/.chainsaw/
<profilable>.properties file)
- a second time with global settings merged with properties gathered from the 
specific property-file in the ~/.chainsaw directory, now containing the needed 
properties

IMHO for Profilables the loadSettings(LoadSettingsEvent event) should be called 
only in the second call (where both global and specific properties are merged)