Bug 40526 - tomcat 5.5.17 catalina.bat - dropped support for JPDA_OPTS environment variable
tomcat 5.5.17 catalina.bat - dropped support for JPDA_OPTS environment variable
Status: RESOLVED FIXED
Product: Tomcat 5
Classification: Unclassified
Component: Catalina
5.5.17
PC Windows XP
: P2 minor (vote)
: ---
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2006-09-16 14:38 UTC by Kurt Roy
Modified: 2007-01-20 07:39 UTC (History)
0 users



Attachments
Zip file that contains correction to catalina.bat and catalina.sh scripts. (6.87 KB, application/x-zip-compressed)
2006-09-16 14:40 UTC, Kurt Roy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Roy 2006-09-16 14:38:15 UTC
We have upgraded from tomcat 4.1.18 to 5.5.17, and have found that our 
system start up process on Windows can no longer set jpda debugger 
options on the tomcat java command line.

This occurs because the 5.5.17 catalina.bat file no longer supports 
the environment variable $JPDA_OPTS, which our start up process used 
to use to place jpda information. What is interesting is that 
catalina.sh STILL supports JPDA_OPTS. So we have this problem on windows only.

Is this an intentional change?

The above comment was sent to tomcate users list. Mark Thomas responded:

Not that I can tell. If you care to create a patch and submit it to bugzilla 
I'll take a look.

I have made the fix, and I am sending it for approval. I have a zip file with 
the correction, and the output of a diff -u on the original and corrected 
version of the catalina.bat and the catalina.sh scripts. I do not see on this 
bug entry page any place to attach this zip file. Please let me know how I can 
send the changes to the community.

Below is a summary of changes made:

Changes include revised catalina.sh and catalina.bat files supporting 
JPDA_OPTS (supported in tomcat 4.1.18), and support for a new JPDA_SUSPEND.

catalina.sh changes:

1. Documented JPDA_OPTS in the script (this was missing) 

2. Added support for JPDA_SUSPEND environment variable. If not specified, it 
defaults to "n" (backward compatible).

catalina.bat changes: 

1. Added back support for JPDA_OPTS. I basically re-implemented as it was in 
tomcat 4.1.18. Note that its only implemented in the non-security execution 
branch (this is how it was in tomcat 4.1.18).

2. Documented JPDA_OPTS in the script.

3. Added support for JPDA_SUSPEND environment variable. If not specified, it 
defaults to "n" (backward compatible).
Comment 1 Kurt Roy 2006-09-16 14:40:51 UTC
Created attachment 18874 [details]
Zip file that contains correction to catalina.bat and catalina.sh scripts.

Attached is a zip file containing revised catalina.sh and catalina.bat files
supporting JPDA_OPTS (supported in tomcat 4.1.18), and support for a new
JPDA_SUSPEND.

catalina.sh changes:

1. Documented JPDA_OPTS in the script (this was missing) 2. Added support for
JPDA_SUSPEND environment variable. If not specified, it defaults to "n"
(backward compatible).

catalina.bat changes: 

1. Added back support for JPDA_OPTS. I basically re-implemented as it was in
tomcat 4.1.18. Note that its only implemented in the non-security execution
branch (this is how it was in tomcat 4.1.18).

2. Documented JPDA_OPTS in the script.

3. Added support for JPDA_SUSPEND environment variable. If not specified, it
defaults to "n" (backward compatible).
Comment 2 Mark Thomas 2007-01-20 07:39:46 UTC
Many thanks for the patch. I have applied the changes to svn and they will be
included in 5.5.21 onwards.