Bug 41437 - The log API used and the log message is not corresponding.
The log API used and the log message is not corresponding.
Status: RESOLVED FIXED
Product: Tomcat 5
Classification: Unclassified
Component: Catalina
5.5.20
PC Windows XP
: P4 trivial (vote)
: ---
Assigned To: Tomcat Developers Mailing List
:
Depends on:
Blocks:
  Show dependency tree
 
Reported: 2007-01-22 16:38 UTC by Suzuki Yuichiro
Modified: 2007-01-23 19:39 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Suzuki Yuichiro 2007-01-22 16:38:44 UTC
The message level is double but not same.

In org.apache.catalina.startup.LocalStrings.properties.
---
contextConfig.role.auth=WARNING: Security role name ...
contextConfig.role.link=WARNING: Security role name ...
contextConfig.role.runas=WARNING: Security role name ...
---

In org.apache.catalina.startup.ContextConfig#validateSecurityRoles()
---
log.info(sm.getString("contextConfig.role.auth", roles[j]));
log.info(sm.getString("contextConfig.role.runas", runAs));
log.info(sm.getString("contextConfig.role.link", link));
---

I think it should be the following. 
---LocalStrings.properties
contextConfig.role.auth=Security role name ...
contextConfig.role.link=Security role name ...
contextConfig.role.runas=Security role name ...

---ContextConfig#validateSecurityRoles()
log.warn(sm.getString("contextConfig.role.auth", roles[j]));
log.warn(sm.getString("contextConfig.role.runas", runAs));
log.warn(sm.getString("contextConfig.role.link", link));
---

Regards,
Yuichiro
Comment 1 Mark Thomas 2007-01-23 19:39:02 UTC
Many thanks for the suggested fix. It has been applied to svn and will be
included in 5.5.21 onwards.