Bug 42082 - filter_init is called multiple times after an INCLUDES filter
Summary: filter_init is called multiple times after an INCLUDES filter
Status: RESOLVED LATER
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: All (show other bugs)
Version: 2.2.2
Hardware: All other
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: MassUpdate
Depends on:
Blocks:
 
Reported: 2007-04-10 12:01 UTC by Joachim Zobel
Modified: 2018-11-07 21:08 UTC (History)
0 users



Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Joachim Zobel 2007-04-10 12:01:49 UTC
Hi.

After an INCLUDES filter a subsequent filters filter_init function is called
once for the main document and once for each included document. It should be
called only once.

To check this a filter is used that counts the calls to filter_init (see below).

The output in the error log is:

[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 1.
[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 2.
[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 3.
[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 4.
[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 5.
[Tue Apr 10 07:43:45 2007] [debug] mod_count_init.c(24): [client 192.168.201.87]
ci_filter_init counted 6.

-------------------------------------------------------------------------------
LoadModule ci_module modules/mod_count_init.so

AddOutputFilter  INCLUDES;count-init .html

bug.html----------------------------------------------------------------------
<html>
<!--#include virtual="test.txt" -->
<!--#include virtual="test.txt" -->
<!--#include virtual="test.txt" -->
<!--#include virtual="test.txt" -->
<!--#include virtual="test.txt" -->
</html>
test.txt----------------------------------------------------------------------
Test
mod_count_init.c--------------------------------------------------------------
/* 
 * Test for an apache 2.2 bug
 */

#include <apr.h>
#include <apr_general.h>
#include <apr_buckets.h>
#include <http_protocol.h>
#include <http_log.h>
#include <mpm.h>

module AP_MODULE_DECLARE_DATA ci_module;

/*****************************************************************************
 * The main filter
 *****************************************************************************/

/*
 * ci_filter_init
 */
static int ci_filter_init(ap_filter_t * f)
{
    int *cnt = (int *)(&f->ctx);
    ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, f->r,
                  "ci_filter_init counted %d.", ++(*cnt));

    return OK;
}

/**
 * Does nothing
 */
static int ci_filter(ap_filter_t * f, apr_bucket_brigade * bb)
{
    return ap_pass_brigade(f->next, bb);
}

/*****************************************************************************
 * The usual module stuff
 *****************************************************************************/

static void ci_hooks(apr_pool_t * p)
{
    ap_register_output_filter("count-init", ci_filter,
                              ci_filter_init, AP_FTYPE_RESOURCE);
}

module AP_MODULE_DECLARE_DATA ci_module = {
    STANDARD20_MODULE_STUFF, NULL, NULL, NULL, NULL,
    NULL, ci_hooks
};
Comment 1 William A. Rowe Jr. 2018-11-07 21:08:36 UTC
Please help us to refine our list of open and current defects; this is a mass update of old and inactive Bugzilla reports which reflect user error, already resolved defects, and still-existing defects in httpd.

As repeatedly announced, the Apache HTTP Server Project has discontinued all development and patch review of the 2.2.x series of releases. The final release 2.2.34 was published in July 2017, and no further evaluation of bug reports or security risks will be considered or published for 2.2.x releases. All reports older than 2.4.x have been updated to status RESOLVED/LATER; no further action is expected unless the report still applies to a current version of httpd.

If your report represented a question or confusion about how to use an httpd feature, an unexpected server behavior, problems building or installing httpd, or working with an external component (a third party module, browser etc.) we ask you to start by bringing your question to the User Support and Discussion mailing list, see [https://httpd.apache.org/lists.html#http-users] for details. Include a link to this Bugzilla report for completeness with your question.

If your report was clearly a defect in httpd or a feature request, we ask that you retest using a modern httpd release (2.4.33 or later) released in the past year. If it can be reproduced, please reopen this bug and change the Version field above to the httpd version you have reconfirmed with.

Your help in identifying defects or enhancements still applicable to the current httpd server software release is greatly appreciated.