Bug 42400 - cleanup and improve file_io flush() and writev() locking
Summary: cleanup and improve file_io flush() and writev() locking
Status: RESOLVED FIXED
Alias: None
Product: APR
Classification: Unclassified
Component: APR (show other bugs)
Version: HEAD
Hardware: Other other
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache Portable Runtime bugs mailinglist
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2007-05-11 18:10 UTC by Davi Arnaut
Modified: 2007-05-12 04:48 UTC (History)
1 user (show)


Attachments
locking check cleanup (4.41 KB, patch)
2007-05-11 18:11 UTC, Davi Arnaut 		Details | Diff
lock-protect the file flushing operation (4.73 KB, patch)
2007-05-11 18:14 UTC, Davi Arnaut 		Details | Diff
lock-protect the writev call (1.55 KB, patch)
2007-05-11 18:15 UTC, Davi Arnaut 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Davi Arnaut 2007-05-11 18:10:49 UTC
Comment 1 Davi Arnaut 2007-05-11 18:11:54 UTC 
Created attachment 20181 [details]
locking check cleanup

Convert the file locking checks to a simple inline function.
Comment 2 Davi Arnaut 2007-05-11 18:14:57 UTC 
Created attachment 20182 [details]
lock-protect the file flushing operation

Lock-protect the file flushing operation. Also, the lock is converted to nested
type because internal callers may be already holding the lock.
Comment 3 Davi Arnaut 2007-05-11 18:15:20 UTC 
Created attachment 20183 [details]
lock-protect the writev call
Comment 4 Bojan Smojver 2007-05-12 04:48:18 UTC 
Committed to trunk in r537393. Thanks for the patches Davi!