Bug 42683 - Can't use '*' for web.xml filter-mapping's servlet-name or url-mapping
Summary: Can't use '*' for web.xml filter-mapping's servlet-name or url-mapping
Status: RESOLVED DUPLICATE of bug 43338
Alias: None
Product: Tomcat 6
Classification: Unclassified
Component: Catalina (show other bugs)
Version: 6.0.11
Hardware: All All
: P2 normal (vote)
Target Milestone: default
Assignee: Tomcat Developers Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-17 11:06 UTC by Sean Owen
Modified: 2008-11-03 06:29 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Owen 2007-06-17 11:06:35 UTC 
Change 504726 to org.apache.catalina.deploy.FilterMap attempts to add support for '*' in web.xml filter-
mapping servlet-name and url-mapping elements 
(http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/deploy/FilterMap.java?
r1=467222&r2=504726). However it does not seem to work as a later validation step fails at about line 
2156 in StandardContext. This code looks at the size of "servletName" and "urlPatterns" arrays from the 
FilterMap object. Since '*' doesn't get added as an element of these arrays, and is handled specially, this 
check will fail if no other url-mapping or servlet-name was specified.

I assume the fix is just to take account of the matchAllServletNames and matchAllUrlPatterns flags too in 
this check.
Comment 1 Mark Thomas 2008-11-03 06:29:12 UTC 

*** This bug has been marked as a duplicate of bug 43338 ***