Bug 42989 - [PATCH] Allow usage of lenya properties in notifier.xconf
Summary: [PATCH] Allow usage of lenya properties in notifier.xconf
Status: NEW
Alias: None
Product: Lenya
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: Trunk
Hardware: All All
: P2 enhancement
Target Milestone: 2.0.1
Assignee: Lenya Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-27 09:51 UTC by Markus Angst
Modified: 2008-01-10 12:39 UTC (History)
0 users



Attachments
Patch for enhancement described above (4.76 KB, patch)
2007-07-27 09:52 UTC, Markus Angst
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Angst 2007-07-27 09:51:51 UTC
This patch allows the usage of lenya properties in attributes of the smtp node
of notifier.xconf:

<smtp host="${smtphost}" username="${username}" password="${password}" />

This file is used by the EmailNotifier. Properties are resolved from all
property files that are handled by PropertiesModule (lenya.properties.xml). This
way you don't have to patch these values in cocoon.xconf during deployment anymore.

This patch is meant to be a proposal. It works for me, but there might most
likely exist better implementations; especially concerning the avalon stuff,
about which I don't have a clue :-). Or maybe this can be generalized to work
with other modules (like contactform), too...
Comment 1 Markus Angst 2007-07-27 09:52:49 UTC
Created attachment 20557 [details]
Patch for enhancement described above
Comment 2 J 2007-10-29 09:57:21 UTC
what about this patch? is it already being dealt with? the feature makes sense
imho, so it would be nice to have it in before 2.0.
it's nicely self-contained, seems to be low risk. i'd commit it, only i don't
have a setup for testing it properly. anyone? jragaller?
Comment 3 Markus Angst 2007-10-29 10:37:20 UTC
The question remains if there is a more generalized approach for this kind of
feature that covers more (or all) modules and their xconf files; at least the
ones that contain deployment specific parameters. One more example would be
defining JDBC datasources in cocoon.xconf. Maybe there is a mechanism in Cocoon
already that i overlooked?