Bug 43275 - Remove avoidable network transactions in mod_proxy_ftp
Summary: Remove avoidable network transactions in mod_proxy_ftp
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: mod_proxy (show other bugs)
Version: 2.5-HEAD
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
Keywords: PatchAvailable
Depends on:
Reported: 2007-08-31 03:58 UTC by rahul
Modified: 2018-02-25 20:32 UTC (History)
0 users

Patch to remove SIZE command. (4.80 KB, patch)
2007-08-31 04:03 UTC, rahul
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rahul 2007-08-31 03:58:18 UTC
When a directory or a file is requested in mod_proxy_ftp, and the user has not
hinted what kind of resource it is(usual), the ftp client in mod_proxy_ftp tries
the command SIZE first, and depending on its output, CWD or RETR.

This is not required. instead, the CWD command can be used to test if the entity
is directory or not, Reducing the number of network transactions required for a
directory listing. This will not impact the normal RETR either.

Moreover SIZE command, though widely implemented, is not part of the original
FTP RFC 959.
Comment 1 rahul 2007-08-31 04:03:07 UTC
Created attachment 20750 [details]
Patch to remove SIZE command.

This was part of the larger patch (41676)

Removes the SIZE command, and instead uses the output of CWD to determine if
the entity is a directory or a file.

Removes the Content-Length header insertion since it is not actually useful 
(From httpd-dev:)
If EOS is sent in the first brigade, then Content-Length is sent, other wise
Chunked encoding is set. There is no explicit control over which header is sent

for the filters.
Comment 2 Rainer Jung 2018-02-25 20:30:36 UTC
Undo spam change