Bug 43471 - no need to create a global pool on open_scoreboard
Summary: no need to create a global pool on open_scoreboard
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: Core (show other bugs)
Version: 2.5-HEAD
Hardware: PC All
: P3 minor (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks:
 
Reported: 2007-09-25 06:58 UTC by Takashi Sato
Modified: 2007-09-25 17:22 UTC (History)
0 users



Attachments
simple (2.52 KB, patch)
2007-09-25 06:59 UTC, Takashi Sato
Details | Diff
big (5.47 KB, patch)
2007-09-25 07:01 UTC, Takashi Sato
Details | Diff
big (5.58 KB, patch)
2007-09-25 17:22 UTC, Takashi Sato
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Takashi Sato 2007-09-25 06:58:20 UTC
hi,

open_scoreboard on server/scoreboard.c says:

    /* We don't want to have to recreate the scoreboard after
     * restarts, so we'll create a global pool and never clean it.
     */
     rv = apr_pool_create(&global_pool, NULL);

This was added on rev 93159.
http://svn.apache.org/viewvc?view=rev&revision=93159

but the pool passed to open_scoreboard is not pconf after rev 94039.
http://svn.apache.org/viewvc?view=rev&revision=94039
Comment 1 Takashi Sato 2007-09-25 06:59:15 UTC
Created attachment 20875 [details]
simple

This is a simple patch to revert r93159
Comment 2 Takashi Sato 2007-09-25 07:01:21 UTC
Created attachment 20876 [details]
big

This is a patch to clarify what kind of pool.
Comment 3 Takashi Sato 2007-09-25 17:22:27 UTC
Created attachment 20881 [details]
big

This is a patch to clarify what kind of pool.
20876 is not enough.