Bug 43769 - chainsaw refactoring of global and default sitemap
Summary: chainsaw refactoring of global and default sitemap
Status: NEW
Alias: None
Product: Lenya
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: Trunk
Hardware: Other other
: P2 enhancement
Target Milestone: 2.0.1
Assignee: Lenya Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-01 06:36 UTC by J
Modified: 2007-11-02 16:14 UTC (History)
0 users



Attachments
proof-of-concept refactoring of central sitemaps (29.65 KB, patch)
2007-11-01 06:39 UTC, J
Details | Diff
next iteration (43.52 KB, patch)
2007-11-01 13:49 UTC, J
Details | Diff
update to current trunk (11.51 KB, patch)
2007-11-02 16:14 UTC, J
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description J 2007-11-01 06:36:50 UTC
as a proof of concept, and as a compensation to the hackathon participants who
had to endure my constant stream of cursing, here's a take-no-prisoners cleanup
of global-sitemap.xmap and pubs/default/sitemap.xmap. both files are about 100
lines shorter now, and there is more potential for simplification.

it breaks everything that i found ugly (most notably our BXE integration and the
webdav hacks in the publication sitemap), but basic functionality is there and
most tests are passed.

goals:
* eliminate code that belongs into modules
* eliminate code duplication, specifically i18n, strip_namespaces,
prettyprinting proxy and uuid2url transforms, which are now gathered in one
global resource

the pipeline flow has been changed so that the stream is handled by global,
passed to publication and then returned to global for post-processing.

module sitemaps have not yet been reviewed.
Comment 1 J 2007-11-01 06:39:07 UTC
Created attachment 21076 [details]
proof-of-concept refactoring of central sitemaps

just a teaser, not suitable for production or even regression testing.
Comment 2 J 2007-11-01 13:49:23 UTC
Created attachment 21078 [details]
next iteration
Comment 3 J 2007-11-02 16:14:24 UTC
Created attachment 21081 [details]
update to current trunk

some whitespace and comment updates are now in trunk. this patch contains only
functional changes and should be a lot more readable than the previous
junkpile.