Bug 44099 - [PATCH] Substitute function in formula cell
Summary: [PATCH] Substitute function in formula cell
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: All All
: P5 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-18 18:51 UTC by Manda Wilson
Modified: 2007-12-21 04:25 UTC (History)
0 users


Attachments
Generated using svn diff > FormulaSubstituteFunction.patch (4.64 KB, patch)
2007-12-18 18:52 UTC, Manda Wilson 		Details | Diff
Contains the files I modified to implement and test the SUBSTITUTE function. (42.97 KB, application/x-gzip)
2007-12-18 18:54 UTC, Manda Wilson 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manda Wilson 2007-12-18 18:51:23 UTC 
I have implemented the SUBSTITUTE function for formula cells.  

I have also filled in the SUBSTITUTE "FORMULA" and "EXPECTED VALUE" rows of the file
src/scratchpad/testcases/org/apache/poi/hssf/data/FormulaEvalTestData.xls with
17 test cases.  All tests pass.
Comment 1 Manda Wilson 2007-12-18 18:52:24 UTC 
Created attachment 21285 [details]
Generated using svn diff > FormulaSubstituteFunction.patch

This is a patch file, generated by running:

svn diff > FormulaSubstituteFunction.patch

After I finished implementing the SUBSTITUTE function.
Comment 2 Manda Wilson 2007-12-18 18:54:16 UTC 
Created attachment 21286 [details]
Contains the files I modified to implement and test the SUBSTITUTE function.

This tar file contains two files that I modified to implement and test the
SUBSTITUTE
formula function.  

The first file is:

src/scratchpad/src/org/apache/poi/hssf/record/formula/functions/Substitute.java


This is where the SUBSTITUTE function is implemented.

The second file is:

src/scratchpad/testcases/org/apache/poi/hssf/data/FormulaEvalTestData.xls

I modified two rows in this file (rows 1296 and 1297), the "FORMULA" and
"EXPECTED VALUE" rows for the SUBSTITUTE function.  This row contains the test
cases for SUBSTITUTE.  These tests run successfully and are run automatically
when the ant
task "test" is executed.
Comment 3 Nick Burch 2007-12-21 04:25:05 UTC 
Thanks, applied