Added try/finally code to POIFSFileSystem constructor to close input stream. Added junit. Added comment to HSSFWorkbook to make this behaviour clear. Added full hierarchy of test suites to aggregate all POI tests. Fixed excluded junit TestEmptyDocument, and added to suite. Updated build.xml to include TestEmptyDocument and mask out new Test Suite classes (naming convention: All*Tests.java).
Created attachment 21480 [details] svn diff showing changes to 6 files
Created attachment 21481 [details] tar bz2 of 9 files (1 test case and 8 test suites)
I think we'll want to discuss this one on dev@ first Can you do a post about why you think this change should be made, what affects it'll have on existing code etc? We can then decide about going ahead with it.
Created attachment 21543 [details] svn diff of one modified file: POIFSFileSystem.java
Created attachment 21544 [details] tar bz2 of one added test case
Thanks for this updated patch Josh. Now applied to svn trunk