Bug 44726 - selectors on remote FTP directories
Summary: selectors on remote FTP directories
Alias: None
Product: Ant
Classification: Unclassified
Component: Optional Tasks (show other bugs)
Version: nightly
Hardware: PC Windows XP
: P2 enhancement with 2 votes (vote)
Target Milestone: 1.8.0
Assignee: Ant Notifications List
Keywords: PatchAvailable
Depends on:
Reported: 2008-04-01 05:34 UTC by Mario Frasca
Modified: 2008-09-26 07:20 UTC (History)
1 user (show)

implementing remote selectors for FTP Task (11.25 KB, patch)
2008-04-02 01:32 UTC, Mario Frasca
Details | Diff
smaller patch, doing the same (implementing remote selectors for FTP Task) (6.95 KB, patch)
2008-04-02 01:41 UTC, Mario Frasca
Details | Diff
same, but 1.3 compliant. (6.93 KB, patch)
2008-04-02 02:32 UTC, Mario Frasca
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mario Frasca 2008-04-01 05:34:58 UTC
I am trying to push ant as a substitute for a custom programmed piece of software at the place where I work currently, but in ant (as in our piece of software) we miss "remote selectors"...  

I have checked out the current copy from subversion and I am looking in the source files and I didn't yet understand whether the current choice -not implementing selectors for remote directories- is a consequence of distant design choices or just lack of time...  I am assuming that it's just because of lack of time, so I'm going to give it a try...  anybody wants to save me a useless effort?

Comment 1 Mario Frasca 2008-04-02 01:29:17 UTC
I have programmed this part...  the patch is attached.  I do have one perplexity, regarding things like "Set<String>" and "Map<String, String[]>" vs. "Set" and "Map"...  I am used to strong type checking and thus to fully parametrize raw types, are there reasons for not doing so?

anyway, I'm enclosing the patch and it works here...

Comment 2 Peter Reilly 2008-04-02 01:31:58 UTC
The main reason is that ant - core is java 1.3 compatible.
Comment 3 Mario Frasca 2008-04-02 01:32:11 UTC
Created attachment 21761 [details]
implementing remote selectors for FTP Task
Comment 4 Mario Frasca 2008-04-02 01:41:01 UTC
Created attachment 21762 [details]
smaller patch, doing the same (implementing remote selectors for FTP Task)

smaller patch, it contains raw types instead of fully parametrized...
Comment 5 Mario Frasca 2008-04-02 02:19:39 UTC
keep it 1.3 compatible...  sorry, didn't notice that...
I'm modifying the preferences in eclipse and will correct the patch right away.
Comment 6 Mario Frasca 2008-04-02 02:32:00 UTC
Created attachment 21763 [details]
same, but 1.3 compliant.
Comment 7 Stefan Bodewig 2008-09-26 07:20:55 UTC
a slightly modified version of your patch (mainly making it more compliant with our predominant coding style) went in as svn revision 699336.