Bug 44821 - [PATCH] patch for XWPF to support extraction of comments, hyperlinks and tables
Summary: [PATCH] patch for XWPF to support extraction of comments, hyperlinks and tables
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: POI Overall (show other bugs)
Version: 3.0-dev
Hardware: PC Windows XP
: P2 normal (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-04-14 05:56 UTC by Yury Batrakov
Modified: 2008-04-27 09:33 UTC (History)
1 user (show)



Attachments
patch itself (4.70 KB, patch)
2008-04-14 05:57 UTC, Yury Batrakov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Batrakov 2008-04-14 05:56:52 UTC
subj
Comment 1 Yury Batrakov 2008-04-14 05:57:38 UTC
Created attachment 21820 [details]
patch itself
Comment 2 Nick Burch 2008-04-27 09:33:45 UTC
Thanks for this patch, it was a helpful starting point.

I've had to make some changes to the code before committing it. Firstly, it broke the existing unit tests, and didn't provide any new ones, so I had to patch it to work with the unit tests

Then, there was the issue that calling extractor.getText() more than once caused the decorations to be applied multiple times. I've changed how the decorators work so that's no longer the case

I suspect we'll need to tweak things some more once we integrate the XmlCursor stuff the XmlBeans guys have suggested, so we can get comments and hyperlinks in-place