Bug 44937 - Patch for PicturesTable.getAllPictures() to support Escher images
Summary: Patch for PicturesTable.getAllPictures() to support Escher images
Alias: None
Product: POI
Classification: Unclassified
Component: HWPF (show other bugs)
Version: 3.0-dev
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: ---
Assignee: POI Developers List
Depends on:
Reported: 2008-05-05 16:23 UTC by Squeeself
Modified: 2008-06-17 14:00 UTC (History)
0 users

Word Escher image extraction (27.51 KB, patch)
2008-05-05 16:23 UTC, Squeeself
Details | Diff
Document for test case (132.50 KB, application/octet-stream)
2008-06-17 13:59 UTC, Squeeself
Image for test case (60.22 KB, image/png)
2008-06-17 14:00 UTC, Squeeself

Note You need to log in before you can comment on or make changes to this bug.
Description Squeeself 2008-05-05 16:23:37 UTC
Created attachment 21923 [details]
Word Escher image extraction

This patch adds support for extracting Escher drawing information from the body of a word document. It also adds support for the FSPA plex to determine what shapes correspond to characters in the document, although no code has been made to do so. The patch also extends PicturesTable.getAllPictures() to extract images from Escher drawings. Note that only pictures from the main body of the document (not headers, etc.) are extracted from Escher drawings with this patch.

There is also a minor fix to EscherClientAnchorRecord. The word format of this record is different from excel, etc., but I haven't found the exact format. This patch fixes the record from throwing an exception when read.

The patch includes a small test case.
Comment 1 Nick Burch 2008-05-20 09:02:33 UTC
Could you please upload GaiaTest.doc and GaiaTestImg.png?

(svn patches do not include binary files)

The rest of the patch has been applied to svn trunk, thanks for that
Comment 2 Josh Micich 2008-05-21 20:06:02 UTC
There were some compiler errors in FSPATable.  It looks like these were some tiny mistakes being hidden by (1.5) auto-boxing. Fixes applied in r658984.

I also made the class a little better encapsulated and type safe.  It doesn't seem to be exercised by any test cases yet.
Comment 3 Squeeself 2008-06-17 13:59:45 UTC
Created attachment 22135 [details]
Document for test case
Comment 4 Squeeself 2008-06-17 14:00:11 UTC
Created attachment 22136 [details]
Image for test case