Created attachment 21975 [details] patch file This patch provides an ability to fetch files embedded in OOXML package.
Thanks for this, applied to the branch Any chance you could upload an OOXML file that contains an embeded document? That way, we'll be able to write a test to ensure it's all working properly. (I'm leaving the bug open for now, until we get the file)
Created attachment 22003 [details] OOXML word file with attachments
Created attachment 22004 [details] OOXML Excel file with attachments
Created attachment 22005 [details] OOXML PPoint file with attachments
I attached word, excel and ppoint files, once i get Visio 2007, I'll upload OOXML visio as well
Thanks for these files, I've added them to svn One thing though - only the word file was coming up with attachments using your patch. Is that expected? (Test is src/ooxml/testcases/org/apache/poi/TestEmbeded.java in the ooxml branch)
hmm, I'll have a look at that
oops, my fault. excel and powerpoint don't store OLE objects' relations in core part as word does. If noone minds me implementing this, I'll fix that
Go for it!
Here I am with the changes: 1. The issue was fixed 2. Also I found out that MS Office has different types for embedded OOXML files and other files. This was took into account: test documents was updated with OOXML attachments (attached) and expected file counts in test were incremented. 3. Extensions .xlsx and .pptx for test files are incorrect - looks like MSOffice chooses them for sheets and slides, but not for workbooks and presentation. Only when I changed them to xlsm and pptm, word started opening them without error messages. I changed them in test, Nick, could you also upload new files and delete old ones?
Created attachment 22012 [details] updated word file
Created attachment 22013 [details] updated patch file
Created attachment 22014 [details] updated excel file
Created attachment 22015 [details] updated ppt file
please read "could you also upload new files" as "could you also check in new files to SVN"
New batch committed to svn, thanks for the quick update Hopefully you now see why we're so keen on unit tests :)
yes, i do see. that was caused by rush i was in finishing my application at my work. in future i promise to test my changes more carefully and write junit tests also :)