File Name: /srclib/apr-util/misc/apr_reslist.c Function Name: reslist_cleanup() Buggy Code: 144: apr_thread_mutex_lock(rl->listlock); 145: 146: while (rl->nidle > 0) { 147: res = pop_resource(rl); 148: rl->ntotal--; 149: rv = destroy_resource(rl, res); 150: if (rv != APR_SUCCESS) 151: return rv; // the execution of apr_thread_mutex_unlock() is missed. Description: We found a rule requiring that apr_thread_mutex_unlock() be called after the execution of apr_thread_mutex_lock(). The call of apr_thread_mutex_unlock() is missed in the above code.
Please select the correct project, component, platform and OS when creating a bug report.
(In reply to comment #1) > Please select the correct project, component, platform and OS when creating a > bug report. In our research project, we develop an approach to discover potential software defects from source code directly by using static program analysis and data mining techniques. In other words, the approach is able to detect potential software defects before the application is deployed. Therefore, this reported bug is not a run-time bug so that I don't have information about the project, component, platform and OS which this bug may be involved in. We would like to know whether this potential bug is a real bug in the source code. (Actually, some bugs discovered by our approach have been confirmed by Apache developers recently).
Last time you reported bugs (and non-bugs), you posted to the mailinglist. Given your approach, that was a sensible thing to do. This is a genuine bug, too - thank you. But you reported it (and two others, which I haven't looked at because they're probably inconsequential) in the wrong place.
(In reply to comment #3) > Last time you reported bugs (and non-bugs), you posted to the mailinglist. > Given your approach, that was a sensible thing to do. > This is a genuine bug, too - thank you. But you reported it (and two others, > which I haven't looked at because they're probably inconsequential) in the > wrong place. Your quick reply is appreciated. Your opinions on two others are important to our research. Please let me know if you have looked at two others. Thanks a lot!
Fixed in trunk in r661063. Will backport if noone screams.
fixed for forthcoming release