Bug 45355 - ab text and html output jumbo unification
Summary: ab text and html output jumbo unification
Status: NEW
Alias: None
Product: Apache httpd-2
Classification: Unclassified
Component: support (show other bugs)
Version: 2.5-HEAD
Hardware: All All
: P2 normal (vote)
Target Milestone: ---
Assignee: Apache HTTPD Bugs Mailing List
URL:
Keywords: PatchAvailable
Depends on:
Blocks: 45356
  Show dependency tree
 
Reported: 2008-07-07 10:47 UTC by Rainer Jung
Modified: 2013-06-01 06:04 UTC (History)
0 users



Attachments
Remove trailing whitespace (1.57 KB, patch)
2008-07-07 10:48 UTC, Rainer Jung
Details | Diff
Fix units in HTML output (1.81 KB, patch)
2008-07-07 10:49 UTC, Rainer Jung
Details | Diff
Add wait time, fix processing time, make write errors output conditional (1.20 KB, patch)
2008-07-07 10:53 UTC, Rainer Jung
Details | Diff
Add missing html output (6.76 KB, patch)
2008-07-07 10:54 UTC, Rainer Jung
Details | Diff
Handle signals in combination with html output (1.30 KB, patch)
2008-07-07 10:55 UTC, Rainer Jung
Details | Diff
Allow gnuplot and csv in combination with html output (4.00 KB, patch)
2008-07-07 10:55 UTC, Rainer Jung
Details | Diff
Use a shared statistics function for html and text output (17.16 KB, patch)
2008-07-07 10:56 UTC, Rainer Jung
Details | Diff
Add confidence and percentile to html output (4.93 KB, patch)
2008-07-07 10:57 UTC, Rainer Jung
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rainer Jung 2008-07-07 10:47:08 UTC
html output generation in ab is a second class citizen. It misses a lot of data, which is output in the text format, and some of the data written out is wrong.

Since the cleanup changes a lot of lines, I provide a series of 8 patches. Each subset 1...n produces a working ab.

The patches are:

- ab.c-whitespace-1.patch: Remove trailing whitespace

- ab.c-units-2.patch: Fix units in HTML output,
  also make placement of scaling factor consistent

- ab.c-proc_wait-3.patch: Add missing wait time in non-confidence output,
  fix processing time in text output, make write errors output conditional
  like for the other errors

- ab.c-missing_html_output-4.patch: Add missing html output part 1
  (ssl_info, err_recv, epipe, mean, wait time)
  and use CONF_FMT_STRING like in the text output case
- ab.c-html_sigs-5.patch: Handle signals in combination with html output
  like in the text case

- ab.c-html_gnuplot_csv-6.patch: Allow gnuplot and csv in combination
  with html output (use common function)

- ab.c-share_statistics-7.patch: Refactor statistics generation to 
  use a shared function for html and text output

- ab.c-html_conf_perc-8.patch: Add confidence and percentile output
  to html output
Comment 1 Rainer Jung 2008-07-07 10:48:38 UTC
Created attachment 22224 [details]
Remove trailing whitespace
Comment 2 Rainer Jung 2008-07-07 10:49:48 UTC
Created attachment 22225 [details]
Fix units in HTML output
Comment 3 Rainer Jung 2008-07-07 10:53:46 UTC
Created attachment 22226 [details]
Add wait time, fix processing time, make write errors output conditional
Comment 4 Rainer Jung 2008-07-07 10:54:21 UTC
Created attachment 22227 [details]
Add missing html output
Comment 5 Rainer Jung 2008-07-07 10:55:00 UTC
Created attachment 22228 [details]
Handle signals in combination with html output
Comment 6 Rainer Jung 2008-07-07 10:55:34 UTC
Created attachment 22229 [details]
Allow gnuplot and csv in combination with html output
Comment 7 Rainer Jung 2008-07-07 10:56:14 UTC
Created attachment 22230 [details]
Use a shared statistics function for html and text output
Comment 8 Rainer Jung 2008-07-07 10:57:06 UTC
Created attachment 22231 [details]
Add confidence and percentile to html output
Comment 9 Rainer Jung 2008-07-07 10:59:25 UTC
All Patches are based on revision 667282. Trunk and 2.2.x of ab.c are the same at the moment.
Comment 10 Christophe JAILLET 2013-03-02 07:43:19 UTC
2nd patch partially addressed r902642
Comment 11 Christophe JAILLET 2013-03-02 08:14:49 UTC
The 2 first patches have been included.
r1451849
Comment 12 Christophe JAILLET 2013-06-01 06:04:26 UTC
3rd patch has been included
r1488471