Bug 45398 - [PATCH] Fix HSSFDateUtil to recognize formats with "AM/PM"
Summary: [PATCH] Fix HSSFDateUtil to recognize formats with "AM/PM"
Status: RESOLVED FIXED
Alias: None
Product: POI
Classification: Unclassified
Component: HSSF (show other bugs)
Version: unspecified
Hardware: All All
: P2 minor (vote)
Target Milestone: ---
Assignee: POI Developers List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-15 08:48 UTC by James
Modified: 2008-07-18 10:16 UTC (History)
0 users


Attachments
patch for org.apache.poi.hssf.usermodel.HSSFDateUtil.java (763 bytes, patch)
2008-07-15 08:48 UTC, James 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James 2008-07-15 08:48:43 UTC 
Created attachment 22258 [details]
patch for org.apache.poi.hssf.usermodel.HSSFDateUtil.java

HSSFDateUtil.isADateFormat(int,String) returns a false negative when evaluating valid date formats containing "AM/PM", "am/pm", "A/P", "a/p". An example is "m/d/yy h:mm AM/PM".

This can be fixed by adding a forward slash to a regex character class in HSSFDateUtil.java. Patch attached.
Comment 1 Nick Burch 2008-07-18 10:16:56 UTC 
Thanks, applied to svn, along with a unit test