Bug 45759 - [PATCH] Internal PDF links from included SVG graphics
Summary: [PATCH] Internal PDF links from included SVG graphics
Status: NEW
Alias: None
Product: Fop - Now in Jira
Classification: Unclassified
Component: pdf (show other bugs)
Version: all
Hardware: All All
: P2 enhancement
Target Milestone: ---
Assignee: fop-dev
Depends on:
Reported: 2008-09-08 01:57 UTC by Stefan Bund
Modified: 2012-04-11 03:21 UTC (History)
1 user (show)

patch against r693020 fop trunk (2.56 KB, application/x-gzip)
2008-09-08 01:58 UTC, Stefan Bund
Counter-proposal (incomplete) (10.38 KB, patch)
2008-09-15 10:23 UTC, Jeremias Maerki
Details | Diff
"link-back" example (SVG link links back into parent XSL-FO) (2.32 KB, application/octet-stream)
2008-09-15 10:25 UTC, Jeremias Maerki
The cut text is highlighted with a red sphere (96.57 KB, image/svg+xml)
2008-10-06 23:07 UTC, Johannes Neubauer

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Bund 2008-09-08 01:57:33 UTC
This patch adds support for internal PDF links to included SVG graphics. A link with a target '#<id>' will be resolved to point to the object with the given target id in the PDF.

Limitations/shortcomings at the moment are:

* Implemented at the renderer stage not the area stage and such only supported
for PDF output
* Resolving the links could certainly be optimized
* The active area will always be rectangular (object bounding box)
* I have only a few days of experience with Apahche-FOP and such there will probably some other shortcomings or missunderstandings.

See the mailing list thread  'Re: Links in SVGs included into PDFs' started at   Tue, 02 Sep 2008 11:02:48 +0200 on fop-users and continued later on fop-dev.
(Thread at gmane: http://thread.gmane.org/gmane.text.xml.fop.user/26778)
Comment 1 Stefan Bund 2008-09-08 01:58:08 UTC
Created attachment 22538 [details]
patch against r693020 fop trunk
Comment 2 Adrian Cumiskey 2008-09-08 06:53:19 UTC
Hi Stefan,

I am pretty busy at the moment but I have just taken a quick look at your patch without trying it out.

My first thoughts are to remove the PDFGraphics2D dependency on the PDFRenderer.  You should be able to just use the PDFDocument member variable to create a PDFFactory and then call makeLink() to make an internal link
and then use a PDFRendererContext to get the currentPage object so you are able to call addAnnotation() from within the PDFGraphics2D implementation.  It would be great if you could revise your patch a little.

Hope this makes sense :).

Comment 3 Stefan Bund 2008-09-08 08:17:02 UTC
My problem is, I have absolutely no experience with Apache-FOP, so atm, everything you try to explain is chinese to me. The other problem is, I just got a new project and will be busy working on that ...

OTOH, I'd love to get the patch into shape. Maybe further discussion on this should move again to the thread on senf-dev since I'd have to ask some more questions on how Apache-FOP works ...
Comment 4 Jeremias Maerki 2008-09-15 10:23:36 UTC
Created attachment 22576 [details]
Counter-proposal (incomplete)

As Adrian noticed, PDFGraphics2D must not have a dependency on PDFRenderer since this class is also used in the PDFTranscoder (for SVG to PDF rendering) where there is no PDFRenderer instance. That's indirectly what I meant by subclassing the PDFAElementBridge and PDFANode. I've create a counter-proposal for this which moves the link generation into the PDFSVGHandler which is used by the PDFRenderer to create in-page SVGs. Parts of the patch are still from your original patch. What's still missing here is a clean way to track the locations of all FOs with an ID as discussed already. This should really be possible without creating a destination object for each such ID. I hope this helps to bring this further.
Comment 5 Jeremias Maerki 2008-09-15 10:25:58 UTC
Created attachment 22577 [details]
"link-back" example (SVG link links back into parent XSL-FO)
Comment 6 Johannes Neubauer 2008-10-06 23:07:28 UTC
Created attachment 22676 [details]
The cut text is highlighted with a red sphere
Comment 7 Johannes Neubauer 2008-10-06 23:08:29 UTC
Please ignore the new attatchement. Wrong bug.
Comment 8 Glenn Adams 2012-04-07 01:43:50 UTC
resetting P2 open bugs to P3 pending further review
Comment 9 Glenn Adams 2012-04-11 03:21:00 UTC
increase priority for bugs with a patch