This patch provides a better error message when an SSL connection arrives on a non-SSL port. Right now the error log message looks like: [Wed Oct 29 11:24:28 2008] [error] [client 127.0.0.1] Invalid method in request \x16\x03\x01 The patch notices that those first few bytes look like an SSL client handshake, and changes the message to: [Wed Oct 29 11:55:14 2008] [error] [client 127.0.0.1] Invalid method in request \x16\x03\x01 - possible attempt to establish SSL connection when the server isn't expecting it which should make the cause a little clearer and easier to fix. Thanks to Eric Covener for suggesting this.
Created attachment 22791 [details] Patch to implement the improved error message
Created attachment 22796 [details] Patch to implement the improved error message Tweak the patch slightly: - Be safe, check r->the_request before dereferencing. - Drop comments to unclutter things, the error message should make clear what the code is looking for
Created attachment 23195 [details] Patch to implement the improved error message Tweak the comment to explain what's being done, and clarify that it's safe here to peek at the first few bytes of r->the_request. Any additional feedback on this patch is welcome.
Committed to trunk by covener http://svn.apache.org/viewvc?rev=739620&view=rev